Message boards :
Number crunching :
What causes a Blank stderr?
Message board moderation
Previous · 1 · 2 · 3
Author | Message |
---|---|
jason_gee Send message Joined: 24 Nov 06 Posts: 7489 Credit: 91,093,184 RAC: 0 |
Yeah, was up to where it can skip path entries without printing that it saw them (still a level out from there). Hadn't spotted a problem in the outer logic going inward, so *should* be OK once he makes that fix. There's a bit of the usual needless spaghettification (namely low 'coupling', i.e. functions so small you end up jumping around like a frog in a sock, likely in the name of excessive reuse, making the call stack too deep for easy navigation). The thread safety concerns applicable to the likes of the stderr (and probably result) files don't apply here internally, so are a separate issue (that can make the deletion fail). I don't see any handle leaks here either. [Edit:] Given its all in a Windows specific preprocessor block, not sure why he didn't use single IFileOperation or SHFileOperation Calls set for recursive deletion. Oh Well. "Living by the wisdom of computer science doesn't sound so bad after all. And unlike most advice, it's backed up by proofs." -- Algorithms to live by: The computer science of human decisions. |
©2024 University of California
SETI@home and Astropulse are funded by grants from the National Science Foundation, NASA, and donations from SETI@home volunteers. AstroPulse is funded in part by the NSF through grant AST-0307956.